netdev - Re: [PATCH][net-next] net/mlx5: Pick the first matched node of priv.free_list in alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b82f5caf-09d7-49be-aa4a-8a402d6b89a2@linux.dev>
Date: Fri, 13 Dec 2024 08:26:58 +0100
From: Zhu Yanjun <yanjun.zhu@...ux.dev>
To: Li RongQing <lirongqing@...du.com>, saeedm@...dia.com, leon@...nel.org,
 tariqt@...dia.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
 linux-rdma@...r.kernel.org
Subject: Re: [PATCH][net-next] net/mlx5: Pick the first matched node of
 priv.free_list in alloc_4k

在 2024/8/23 8:16, Li RongQing 写道:
> Pick the first node instead of last, to avoid unnecessary iterating
> over whole free list
> 
> Signed-off-by: Li RongQing <lirongqing@...du.com>

Your commit is to fix the problem from the following commit?
So the following should be needed.

Fixes: 2726cd4a2928 ("net/mlx5: Dedicate fw page to the requesting function"

commit 2726cd4a29280c20ea983be285a6aefe75b205a4
Author: Eran Ben Elisha <eranbe@...lanox.com>
Date:   Sun May 3 10:15:58 2020 +0300

     net/mlx5: Dedicate fw page to the requesting function

     The cited patch assumes that all chuncks in a fw page belong to the 
same
     function, thus the driver must dedicate fw page to the requesting
     function, which is actually what was intedned in the original fw pages
     allocator design, hence the fwp->func_id !

     Up until the cited patch everything worked ok, but now "relase all 
pages"
     is broken on systems with page_size > 4k.

     Fix this by dedicating fw page to the requesting function id via 
adding a
     func_id parameter to alloc_4k() function.

     Fixes: c6168161f693 ("net/mlx5: Add support for release all pages 
event")
     Signed-off-by: Eran Ben Elisha <eranbe@...lanox.com>
     Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>

Zhu Yanjun

> ---
>   drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
> index 972e8e9..cd20f11 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
> @@ -228,6 +228,7 @@ static int alloc_4k(struct mlx5_core_dev *dev, u64 *addr, u32 function)
>   		if (iter->function != function)
>   			continue;
>   		fp = iter;
> +		break;
>   	}
>   
>   	if (list_empty(&dev->priv.free_list) || !fp)