netdev - Re: [PATCH v2 net-next 12/15] socket: Remove kernel socket conversion.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241213082837.7994-1-kuniyu@amazon.com>
Date: Fri, 13 Dec 2024 17:28:37 +0900
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <allison.henderson@...cle.com>
CC: <chuck.lever@...cle.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<horms@...nel.org>, <jaka@...ux.ibm.com>, <jlayton@...nel.org>,
	<kuba@...nel.org>, <kuni1840@...il.com>, <kuniyu@...zon.com>,
	<matttbe@...nel.org>, <netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<sfrench@...ba.org>, <wenjia@...ux.ibm.com>
Subject: Re: [PATCH v2 net-next 12/15] socket: Remove kernel socket conversion.

From: Allison Henderson <allison.henderson@...cle.com>
Date: Thu, 12 Dec 2024 17:35:39 +0000
> On Tue, 2024-12-10 at 18:20 -0800, Jakub Kicinski wrote:
> > On Tue, 10 Dec 2024 16:38:26 +0900 Kuniyuki Iwashima wrote:
> > > +	net = rds_conn_net(conn);
> > > +
> > >  	if (rds_conn_path_up(cp)) {
> > >  		mutex_unlock(&tc->t_conn_path_lock);
> > >  		return 0;
> > >  	}
> > > +
> > > +	if (!maybe_get_net(net))
> > > +		return -EINVAL;
> > 
> > FWIW missing unlock here.

Thanks for catching!


> 
> Oh, good catch!  Yes, we need a mutex unlock before the return -EINVAL.  Kuniyuki, can you send an update?  Thanks!
>

Yes, will do.

Thanks!