netdev - Re: [PATCH v2] net: ethernet: bgmac-platform: fix an OF node reference leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241216145637.GD780307@kernel.org>
Date: Mon, 16 Dec 2024 14:56:37 +0000
From: Simon Horman <horms@...nel.org>
To: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
Cc: rafal@...ecki.pl, bcm-kernel-feedback-list@...adcom.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: ethernet: bgmac-platform: fix an OF node
 reference leak

On Sat, Dec 14, 2024 at 10:49:12AM +0900, Joe Hattori wrote:
> The OF node obtained by of_parse_phandle() is not freed. Call
> of_node_put() to balance the refcount.
> 
> This bug was found by an experimental static analysis tool that I am
> developing.
> 
> Fixes: 1676aba5ef7e ("net: ethernet: bgmac: device tree phy enablement")
> Signed-off-by: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
> ---
> Changes in V2:
> - Avoid using the __free() construct.

Thanks for the update.

Reviewed-by: Simon Horman <horms@...nel.org>