netdev - Re: [PATCH net-next 6/7] ice: dump ethtool stats and skb by Tx hang devlink health reporter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a71791c-a73a-4a3c-8573-7b80d1c39d57@intel.com>
Date: Mon, 16 Dec 2024 05:53:03 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, <jiri@...nulli.us>, "Knitter, Konrad"
	<konrad.knitter@...el.com>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<andrew+netdev@...n.ch>, <netdev@...r.kernel.org>,
	<wojciech.drewek@...el.com>, <mateusz.polchlopek@...el.com>,
	<joe@...ches.com>, <horms@...nel.org>, <apw@...onical.com>,
	<lukas.bulwahn@...il.com>, <dwaipayanray1@...il.com>, Igor Bagnucki
	<igor.bagnucki@...el.com>, Pucha Himasekhar Reddy
	<himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next 6/7] ice: dump ethtool stats and skb by Tx hang
 devlink health reporter

On 12/13/24 04:00, Jakub Kicinski wrote:
> On Wed, 11 Dec 2024 14:32:14 -0800 Tony Nguyen wrote:
>> From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>>
>> Print the ethtool stats and skb diagnostic information as part of Tx hang
>> devlink health dump.
>>
>> Move the declarations of ethtool functions that devlink health uses out
>> to a new file: ice_ethtool_common.h
>>
>> To utilize our existing ethtool code in this context, convert it to
>> non-static.
> 
> This is going too far, user space is fully capable of capturing this
> data. It gets a netlink notification when health reporter flips to
> a bad state. 

It really pays to split your patches into trivial vs controversial ones.

Will it be fine to merge this series without patch 6 (and 3) then?
Patches 2, 4 and 5 are dependency for another health reporters that
Konrad did:
https://lore.kernel.org/intel-wired-lan/20241211110357.196167-1-konrad.knitter@intel.com

>I think Jiri worked on a daemon what could capture more
> data from user space ? I may be misremembering...

We would love to read more on that, then with more knowledge revisit
what to do about our needs covered by this patch.