netdev - Re: [PATCH net-next] mlxsw: Switch to napi_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35e07596-1153-4e40-9fb7-d06703b82804@intel.com>
Date: Mon, 16 Dec 2024 18:44:18 +0100
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Petr Machata <petrm@...dia.com>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	<netdev@...r.kernel.org>, Ido Schimmel <idosch@...dia.com>,
	<mlxsw@...dia.com>, Amit Cohen <amcohen@...dia.com>
Subject: Re: [PATCH net-next] mlxsw: Switch to napi_gro_receive()

From: Petr Machata <petrm@...dia.com>
Date: Mon, 16 Dec 2024 14:18:44 +0100

> From: Ido Schimmel <idosch@...dia.com>
> 
> Benefit from the recent conversion of the driver to NAPI and enable GRO
> support through the use of napi_gro_receive(). Pass the NAPI pointer
> from the bus driver (mlxsw_pci) to the switch driver (mlxsw_spectrum)
> through the skb control block where various packet metadata is already
> encoded.
> 
> The main motivation is to improve forwarding performance through the use
> of GRO fraglist [1]. In my testing, when the forwarding data path is
> simple (routing between two ports) there is not much difference in
> forwarding performance between GRO disabled and GRO enabled with
> fraglist.
> 
> The improvement becomes more noticeable as the data path becomes more
> complex since it is traversed less times with GRO enabled. For example,
> with 10 ingress and 10 egress flower filters with different priorities
> on the two ports between which routing is performed, there is an
> improvement of about 140% in forwarded bandwidth.
> 
> [1] https://lore.kernel.org/netdev/20200125102645.4782-1-steffen.klassert@secunet.com/
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Amit Cohen <amcohen@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

Thanks,
Olek