netdev - Re: [PATCH RFC net 0/2] net: dsa: felix: fix VLAN-unaware reception

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241217101541.GK780307@kernel.org>
Date: Tue, 17 Dec 2024 10:15:41 +0000
From: Simon Horman <horms@...nel.org>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: Robert Hodaszi <robert.hodaszi@...i.com>, netdev@...r.kernel.org,
	claudiu.manoil@....com, alexandre.belloni@...tlin.com,
	UNGLinuxDriver@...rochip.com, andrew@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC net 0/2] net: dsa: felix: fix VLAN-unaware reception

On Mon, Dec 16, 2024 at 04:48:31PM +0200, Vladimir Oltean wrote:
> On Mon, Dec 16, 2024 at 03:39:17PM +0100, Robert Hodaszi wrote:
> > Actually, what you did is exactly what I did first to fix the issue, but it broke my setup when I sent VLAN-tagged messages to the device. Now I tested again, and it is working fine. That made me think it's happening because it is stripping incorrectly the VLAN tag. Probably it was just an incorrect setup, maybe something remained set either on my PC or on the unit from the previous test.
> > 
> > One thing is different to my change though: you're calling the br_vlan_get_proto() twice. You can tweak performance a bit probably, if you rather pass 'proto' to both dsa_software_untag_vlan_aware_bridge and dsa_software_untag_vlan_unaware_bridge instead. So something like this:
> 
> The patch is going to become stuffy, but ok. We also have to update the
> kernel-doc of the 2 untagging functions to document the new argument.
> I will send a v2 tomorrow after the expiry of the 24 hour timeout for
> other review comments.

Hi Vladimir,

As you are touching both Kernel doc and dsa_software_vlan_untag,
could you consider also adding a "Returns: " section to the Kernel doc
of that function?