netdev - Re: [PATCH] net: stmmac: call stmmac_remove_config_dt() in error paths in stmmac_probe_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec8509c2-1124-4f8a-b831-459d084ac726@stanley.mountain>
Date: Tue, 17 Dec 2024 14:27:26 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
Cc: alexandre.torgue@...s.st.com, joabreu@...opsys.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, mcoquelin.stm32@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: call stmmac_remove_config_dt() in error
 paths in stmmac_probe_config_dt()

On Tue, Dec 17, 2024 at 12:32:43PM +0900, Joe Hattori wrote:
> Also, remove the first argument of stmmac_remove_config_dt() as it is not
> used.

Don't do that.  It makes the patch difficult to review.

regards,
dan carpenter