netdev - Re: [PATCH net] udp: fix l4 hash after reconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b6c15ec-64ce-4d7f-8b36-6faacc038b55@linux.alibaba.com>
Date: Tue, 17 Dec 2024 20:16:59 +0800
From: Philo Lu <lulie@...ux.alibaba.com>
To: Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 David Ahern <dsahern@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Simon Horman <horms@...nel.org>, Fred Chen <fred.cc@...baba-inc.com>,
 Cambda Zhu <cambda@...ux.alibaba.com>, Willem de Bruijn
 <willemb@...gle.com>, Stefano Brivio <sbrivio@...hat.com>
Subject: Re: [PATCH net] udp: fix l4 hash after reconnect

On 2024/12/11 08:59, Jakub Kicinski wrote:
> On Fri,  6 Dec 2024 16:49:14 +0100 Paolo Abeni wrote:
>> After the blamed commit below, udp_rehash() is supposed to be called
>> with both local and remote addresses set.
>>
>> Currently that is already the case for IPv6 sockets, but for IPv4 the
>> destination address is updated after rehashing.
>>
>> Address the issue moving the destination address and port initialization
>> before rehashing.
>>
>> Fixes: 1b29a730ef8b ("ipv6/udp: Add 4-tuple hash for connected socket")
>> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> 
> I feel obliged to point out a lack of selftest both here and the series
> under Fixes :(

Sorry for the late reply.

Though I'm glad to add selftests, I don't have a good idea how to do it 
decently. Because the series (say uhash4) will take effect silently for 
connected udp sockets without any api change.

Maybe it's better to add KUnit tests for it? or any other suggestions?

Thanks.
-- 
Philo