netdev - Re: [PATCH net-next 02/12] net/mlx5: LAG, Refactor lag logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241217065822.4243007f@kernel.org>
Date: Tue, 17 Dec 2024 06:58:22 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Mark Bloch <mbloch@...dia.com>
Cc: Alexander Lobakin <aleksander.lobakin@...el.com>, rongwei liu
 <rongweil@...dia.com>, Tariq Toukan <tariqt@...dia.com>, "David S. Miller"
 <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Eric Dumazet
 <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>, Leon Romanovsky
 <leonro@...dia.com>, netdev@...r.kernel.org, Saeed Mahameed
 <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>
Subject: Re: [PATCH net-next 02/12] net/mlx5: LAG, Refactor lag logic

On Tue, 17 Dec 2024 14:52:55 +0200 Mark Bloch wrote:
> > All drivers must have its symbols prefixed, otherwise there might be
> > name conflicts at anytime and also it's not clear where a definition
> > comes from if it's not prefixed.
> 
> However, those aren't exported symbols, they are used exclusively by the mlx5 lag code.
> I don't see any added value in prefixing internal functions with mlx5 unless it adds
> context to the logic.
> Here it's very clear we are going over the members that are stored inside the ldev struct.

Prefixing the symbols makes it easier to read your code for people 
who aren't exclusively working on mlx5. Also useful when reading
mlx5-originated stack traces.