Message-ID: <alpine.DEB.2.22.394.2412171831300.3566@hadrien>
Date: Tue, 17 Dec 2024 18:33:18 +0100 (CET)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Alexander Gordeev <agordeev@...ux.ibm.com>
cc: Easwar Hariharan <eahariha@...ux.microsoft.com>, 
    Pablo Neira Ayuso <pablo@...filter.org>, 
    Jozsef Kadlecsik <kadlec@...filter.org>, 
    "David S. Miller" <davem@...emloft.net>, 
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
    Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
    Julia Lawall <Julia.Lawall@...ia.fr>, 
    Nicolas Palix <nicolas.palix@...g.fr>, Daniel Mack <daniel@...que.org>, 
    Haojian Zhuang <haojian.zhuang@...il.com>, 
    Robert Jarzmik <robert.jarzmik@...e.fr>, 
    Russell King <linux@...linux.org.uk>, Heiko Carstens <hca@...ux.ibm.com>, 
    Vasily Gorbik <gor@...ux.ibm.com>, 
    Christian Borntraeger <borntraeger@...ux.ibm.com>, 
    Sven Schnelle <svens@...ux.ibm.com>, Ofir Bitton <obitton@...ana.ai>, 
    Oded Gabbay <ogabbay@...nel.org>, 
    Lucas De Marchi <lucas.demarchi@...el.com>, 
    Thomas Hellström <thomas.hellstrom@...ux.intel.com>, 
    Rodrigo Vivi <rodrigo.vivi@...el.com>, 
    Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
    Maxime Ripard <mripard@...nel.org>, 
    Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, 
    Simona Vetter <simona@...ll.ch>, Jeroen de Borst <jeroendb@...gle.com>, 
    Praveen Kaligineedi <pkaligineedi@...gle.com>, 
    Shailend Chand <shailend@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
    James Smart <james.smart@...adcom.com>, 
    Dick Kennedy <dick.kennedy@...adcom.com>, 
    "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, 
    "Martin K. Petersen" <martin.petersen@...cle.com>, 
    Roger Pau Monné <roger.pau@...rix.com>, 
    Jens Axboe <axboe@...nel.dk>, Kalle Valo <kvalo@...nel.org>, 
    Jeff Johnson <jjohnson@...nel.org>, 
    Catalin Marinas <catalin.marinas@....com>, 
    Andrew Morton <akpm@...ux-foundation.org>, 
    Jack Wang <jinpu.wang@...ud.ionos.com>, 
    Marcel Holtmann <marcel@...tmann.org>, 
    Johan Hedberg <johan.hedberg@...il.com>, 
    Luiz Augusto von Dentz <luiz.dentz@...il.com>, 
    Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
    Florian Fainelli <florian.fainelli@...adcom.com>, 
    Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, 
    Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
    Xiubo Li <xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>, 
    Josh Poimboeuf <jpoimboe@...nel.org>, Jiri Kosina <jikos@...nel.org>, 
    Miroslav Benes <mbenes@...e.cz>, Petr Mladek <pmladek@...e.com>, 
    Joe Lawrence <joe.lawrence@...hat.com>, Jaroslav Kysela <perex@...ex.cz>, 
    Takashi Iwai <tiwai@...e.com>, Louis Peens <louis.peens@...igine.com>, 
    Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, 
    Christophe Leroy <christophe.leroy@...roup.eu>, 
    Naveen N Rao <naveen@...nel.org>, 
    Madhavan Srinivasan <maddy@...ux.ibm.com>, netfilter-devel@...r.kernel.org, 
    coreteam@...filter.org, netdev@...r.kernel.org, 
    linux-kernel@...r.kernel.org, cocci@...ia.fr, 
    linux-arm-kernel@...ts.infradead.org, linux-s390@...r.kernel.org, 
    dri-devel@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org, 
    linux-scsi@...r.kernel.org, xen-devel@...ts.xenproject.org, 
    linux-block@...r.kernel.org, linux-wireless@...r.kernel.org, 
    ath11k@...ts.infradead.org, linux-mm@...ck.org, 
    linux-bluetooth@...r.kernel.org, linux-staging@...ts.linux.dev, 
    linux-rpi-kernel@...ts.infradead.org, ceph-devel@...r.kernel.org, 
    live-patching@...r.kernel.org, linux-sound@...r.kernel.org, 
    oss-drivers@...igine.com, linuxppc-dev@...ts.ozlabs.org, 
    Anna-Maria Behnsen <anna-maria@...utronix.de>
Subject: Re: [PATCH v3 02/19] coccinelle: misc: Add secs_to_jiffies script



On Tue, 17 Dec 2024, Alexander Gordeev wrote:

> On Tue, Dec 10, 2024 at 10:02:33PM +0000, Easwar Hariharan wrote:
>
> Hi Easwar,
>
> > This script finds and suggests conversions of timeout patterns that
> > result in seconds-denominated timeouts to use the new secs_to_jiffies()
> > API in include/linux/jiffies.h for better readability.
> >
> > Suggested-by: Anna-Maria Behnsen <anna-maria@...utronix.de>
> > Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
> > ---
> >  scripts/coccinelle/misc/secs_to_jiffies.cocci | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >
> > diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..8bbb2884ea5db939c63fd4513cf5ca8c977aa8cb
> > --- /dev/null
> > +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci
> > @@ -0,0 +1,22 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +///
> > +/// Find usages of:
> > +/// - msecs_to_jiffies(value*1000)
> > +/// - msecs_to_jiffies(value*MSEC_PER_SEC)
> > +///
> > +// Confidence: High
> > +// Copyright: (C) 2024 Easwar Hariharan, Microsoft
> > +// Keywords: secs, seconds, jiffies
> > +//
> > +
> > +virtual patch
> > +
> > +@...ends on patch@ constant C; @@
> > +
> > +- msecs_to_jiffies(C * 1000)
> > ++ secs_to_jiffies(C)
> > +
> > +@...ends on patch@ constant C; @@
> > +
> > +- msecs_to_jiffies(C * MSEC_PER_SEC)
> > ++ secs_to_jiffies(C)
>
> If you used this script only, then it did not seem to recognize line arch/s390/mm/cmm.c:207
>
> 	mod_timer(&cmm_timer, jiffies + msecs_to_jiffies(cmm_timeout_seconds * MSEC_PER_SEC));

There is the requirement that C is a constant, and cmm_timeout_seconds is
not considered to be a constant, ie it is not all capital letters.
Indeed, it doesn't seem to be a constant at all.  I don't know if the
requirement of being a comstant is really necessary.

julia

>
> Thanks!
>

Powered by blists - more mailing lists