netdev - Re: [PATCH net-next 5/5] l2tp: Use inet_sk_init_flowi4() in l2tp_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14f4b2ce-37b0-e187-17e3-004ebc29ef99@katalix.com>
Date: Tue, 17 Dec 2024 08:00:01 +0000
From: James Chapman <jchapman@...alix.com>
To: Guillaume Nault <gnault@...hat.com>, David Miller <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>
Cc: netdev@...r.kernel.org, Simon Horman <horms@...nel.org>,
 David Ahern <dsahern@...nel.org>, Tom Parkin <tparkin@...alix.com>
Subject: Re: [PATCH net-next 5/5] l2tp: Use inet_sk_init_flowi4() in
 l2tp_ip_sendmsg().

On 16/12/2024 17:21, Guillaume Nault wrote:
> Use inet_sk_init_flowi4() to automatically initialise the flowi4
> structure in l2tp_ip_sendmsg() instead of passing parameters manually
> to ip_route_output_ports().
> 
> Override ->daddr with the value passed in the msghdr structure if
> provided.
> 
> Signed-off-by: Guillaume Nault <gnault@...hat.com>

This all looks good to me.

Reviewed-by: James Chapman <jchapman@...alix.com>