netdev - Re: [PATCH net-next 1/3] net: mctp: handle skb cleanup on sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5825fee13fa794dbe91f3e36224085a37c725d3b.camel@codeconstruct.com.au>
Date: Tue, 17 Dec 2024 16:51:35 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Paolo Abeni <pabeni@...hat.com>, Matt Johnston
 <matt@...econstruct.com.au>,  "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Simon
 Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] net: mctp: handle skb cleanup on
 sock_queue failures

Hi Paolo,

> Why are you targeting net-next for this patch? it looks like a clean
> fix for net, and follow-up patches don't depend on it.

Just that I wasn't confident that this would qualify for net; given you
have indicated so, I'll split and resend.

> >                 /* we need to be continuing an existing reassembly... */
> > -               if (!key->reasm_head)
> > -                       rc = -EINVAL;
> > -               else
> > +               if (key->reasm_head)
> >                         rc = mctp_frag_queue(key, skb);
> > +               else
> > +                       rc = -EINVAL;
> 
> This chunk just re-order existing statement, it looks unneeded and I
> would remove it from 'net' fix.

Yep, makes sense, as well as the goto for the early exit here.

I'll follow-up with a v2 for both net (1/3) and net-next (2/3 & 3/3).

Cheers,

Jeremy