netdev - Re: [PATCH net-next] net/mlx5: use do_aux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbed26a2-4b59-4c99-b5e7-2ca55a666450@linux.dev>
Date: Wed, 18 Dec 2024 10:19:59 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Richard Cochran <richardcochran@...il.com>
Cc: Dragos Tatulea <dtatulea@...dia.com>, Gal Pressman <gal@...dia.com>,
 Jakub Kicinski <kuba@...nel.org>, Tariq Toukan <tariqt@...dia.com>,
 Carolina Jubran <cjubran@...dia.com>, Bar Shapira <bshapira@...dia.com>,
 netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
 Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>,
 Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH net-next] net/mlx5: use do_aux_work for PHC overflow
 checks

On 18/12/2024 03:52, Richard Cochran wrote:
> On Tue, Dec 17, 2024 at 11:57:38AM -0800, Vadim Fedorenko wrote:
>> The overflow_work is using system wq to do overflow checks and updates
>> for PHC device timecounter, which might be overhelmed by other tasks.
>> But there is dedicated kthread in PTP subsystem designed for such
>> things. This patch changes the work queue to proper align with PTP
>> subsystem and to avoid overloading system work queue.
> 
> Yes, and you can configure that thread with chrt to ensure timely
> invocation of the callback.
> 
>> @@ -1188,7 +1192,6 @@ void mlx5_cleanup_clock(struct mlx5_core_dev *mdev)
>>   	}
>>   
>>   	cancel_work_sync(&clock->pps_info.out_work);
>> -	cancel_delayed_work_sync(&clock->timer.overflow_work);
> 
> Do you need ptp_cancel_worker_sync() ?

ptp_clock_unregister() calls kthread_cancel_delayed_work_sync() if
ptp->kworker exists, no need to call ptp_cancel_worker_sync() on cleanup.

> 
> Thanks,
> Richard