netdev - Re: [PATCH net-next] net: netlink: catch attempts to send empty messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+KkT2nzdb4R=gfvKWw3oqnBZQx+umAT+5zFsUrLvZQoA@mail.gmail.com>
Date: Wed, 18 Dec 2024 11:40:04 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next] net: netlink: catch attempts to send empty messages

On Wed, Dec 18, 2024 at 3:44 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> syzbot can figure out a way to redirect a netlink message to a tap.
> Sending empty skbs to devices is not valid and we end up hitting
> a skb_assert_len() in __dev_queue_xmit().
>
> Make catching these mistakes easier, assert the skb size directly
> in netlink core.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>