netdev - Re: [PATCH net-next 2/3] net: hisilicon: hns: Remove unused hns_rcb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c12c521e-a47c-46a0-ac1d-ff669c24605b@huawei.com>
Date: Wed, 18 Dec 2024 19:58:04 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: <linux@...blig.org>, <salil.mehta@...wei.com>, <shenjian15@...wei.com>,
	<andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>
CC: <shaojijie@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 2/3] net: hisilicon: hns: Remove unused
 hns_rcb_start


on 2024/12/18 8:57, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> hns_rcb_start() has been unused since 2016's
> commit 454784d85de3 ("net: hns: delete redundancy ring enable operations")
>
> Remove it.

Thanks,
Reviewed-by: Jijie Shao<shaojijie@...wei.com>

>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>   drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 5 -----
>   drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h | 1 -
>   2 files changed, 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c
> index 46af467aa596..635b3a95dd82 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c
> @@ -195,11 +195,6 @@ void hns_rcb_ring_enable_hw(struct hnae_queue *q, u32 val)
>   	dsaf_write_dev(q, RCB_RING_PREFETCH_EN_REG, !!val);
>   }
>   
> -void hns_rcb_start(struct hnae_queue *q, u32 val)
> -{
> -	hns_rcb_ring_enable_hw(q, val);
> -}
> -
>   /**
>    *hns_rcb_common_init_commit_hw - make rcb common init completed
>    *@..._common: rcb common device
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h
> index 0f4cc184ef39..68f81547dfb4 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h
> @@ -116,7 +116,6 @@ int hns_rcb_buf_size2type(u32 buf_size);
>   int hns_rcb_common_get_cfg(struct dsaf_device *dsaf_dev, int comm_index);
>   void hns_rcb_common_free_cfg(struct dsaf_device *dsaf_dev, u32 comm_index);
>   int hns_rcb_common_init_hw(struct rcb_common_cb *rcb_common);
> -void hns_rcb_start(struct hnae_queue *q, u32 val);
>   int hns_rcb_get_cfg(struct rcb_common_cb *rcb_common);
>   void hns_rcb_get_queue_mode(enum dsaf_mode dsaf_mode,
>   			    u16 *max_vfn, u16 *max_q_per_vf);