netdev - Re: [PATCH net-next] sfc: remove efx_writed_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f8615c6-3c36-4094-8c62-bf792fc30b79@intel.com>
Date: Wed, 18 Dec 2024 16:42:04 +0100
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: <edward.cree@....com>
CC: <linux-net-drivers@....com>, <davem@...emloft.net>, <kuba@...nel.org>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, Andy Moreton
	<andy.moreton@....com>, <netdev@...r.kernel.org>, <habetsm.xilinx@...il.com>,
	Edward Cree <ecree.xilinx@...il.com>
Subject: Re: [PATCH net-next] sfc: remove efx_writed_page_locked

From: Edward.cree <edward.cree@....com>
Date: Wed, 18 Dec 2024 13:59:30 +0000

> From: Andy Moreton <andy.moreton@....com>
> 
> From: Andy Moreton <andy.moreton@....com>

The patch is fine, but here clearly should be only one "From:" line.

> 
> efx_writed_page_locked is a workaround for Siena hardware that is not
> needed on later adapters, and has no callers. Remove it.
> 
> Signed-off-by: Andy Moreton <andy.moreton@....com>
> Signed-off-by: Edward Cree <ecree.xilinx@...il.com>
> ---
>  drivers/net/ethernet/sfc/io.h | 24 ------------------------
>  1 file changed, 24 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/io.h b/drivers/net/ethernet/sfc/io.h
> index 4cc7b501135f..ef374a8e05c3 100644
> --- a/drivers/net/ethernet/sfc/io.h
> +++ b/drivers/net/ethernet/sfc/io.h
> @@ -217,28 +217,4 @@ _efx_writed_page(struct efx_nic *efx, const efx_dword_t *value,
>  					   (reg) != 0xa1c),		\
>  			 page)
>  
> -/* Write TIMER_COMMAND.  This is a page-mapped 32-bit CSR, but a bug
> - * in the BIU means that writes to TIMER_COMMAND[0] invalidate the
> - * collector register.
> - */
> -static inline void _efx_writed_page_locked(struct efx_nic *efx,
> -					   const efx_dword_t *value,
> -					   unsigned int reg,
> -					   unsigned int page)
> -{
> -	unsigned long flags __attribute__ ((unused));
> -
> -	if (page == 0) {
> -		spin_lock_irqsave(&efx->biu_lock, flags);
> -		efx_writed(efx, value, efx_paged_reg(efx, page, reg));
> -		spin_unlock_irqrestore(&efx->biu_lock, flags);
> -	} else {
> -		efx_writed(efx, value, efx_paged_reg(efx, page, reg));
> -	}
> -}
> -#define efx_writed_page_locked(efx, value, reg, page)			\
> -	_efx_writed_page_locked(efx, value,				\
> -				reg + BUILD_BUG_ON_ZERO((reg) != 0x420), \
> -				page)
> -
>  #endif /* EFX_IO_H */

Thanks,
Olek