netdev - Re: [Intel-wired-lan] [net-next] ice: expose non_eop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e6d4fa08-b0ce-4014-a8cf-3d7a034c99a1@intel.com>
Date: Wed, 18 Dec 2024 16:51:33 +0100
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Jonathan Maxwell <jmaxwell37@...il.com>
CC: <anthony.l.nguyen@...el.com>, <przemyslaw.kitszel@...el.com>,
	<andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <intel-wired-lan@...ts.osuosl.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [net-next] ice: expose non_eop_descs to ethtool

From: Jonathan Maxwell <jmaxwell37@...il.com>
Date: Wed, 18 Dec 2024 09:13:00 +1100

> On Wed, Dec 18, 2024 at 1:49 AM Alexander Lobakin
> <aleksander.lobakin@...el.com> wrote:
>>
>> From: Jon Maxwell <jmaxwell37@...il.com>
>> Date: Tue, 17 Dec 2024 10:48:50 +1100
>>
>>> The ixgbe driver exposes non_eop_descs to ethtool. Do the same for ice.
>>
>> Only due to that?
>> Why would we need it in the first place?
>>
> 
> Not just that. We had a critical ice bug we were diagnosing and saw this
> counter in the Vmcore. When we set up a reproducer we needed to check that
> counter was incrementing. I added this patch to do that and thought that
> it may aid trouble-shooting in the future as well so I sent it upstream.

ethtool -S is slowly getting deprecated, I wouldn't encourage exporting
more new stats. The best thing you could do is to add such field to the
generic per-queue stats and implement them in ice.

> 
> Regards
> 
> Jon

Thanks,
Olek