netdev - Re: [PATCH iwl-next 2/3] ice: lower the latency of GNSS reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA0PR11MB838025A665D960208095BAC086052@IA0PR11MB8380.namprd11.prod.outlook.com>
Date: Wed, 18 Dec 2024 16:23:10 +0000
From: "Kolacinski, Karol" <karol.kolacinski@...el.com>
To: "Schmidt, Michal" <mschmidt@...hat.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Kubalewski, Arkadiusz"
	<arkadiusz.kubalewski@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, Miroslav Lichvar <mlichvar@...hat.com>
Subject: Re: [PATCH iwl-next 2/3] ice: lower the latency of GNSS reads

On 12.12.2024 16:34 CET, Michal Schmidt <mschmidt@...hat.com> wrote:
> The E810 is connected to the u-blox GNSS module over I2C. The ice driver
> periodically (every ~20ms) sends AdminQ commands to poll the u-blox for
> available data. Most of the time, there's no data. When the u-blox
> finally responds that data is available, usually it's around 800 bytes.
> It can be more or less, depending on how many NMEA messages were
> configured using ubxtool. ice then proceeds to read all the data.
> AdminQ and I2C are slow. The reading is performed in chunks of 15 bytes.
> ice reads all of the data before passing it to the kernel GNSS subsystem
> and onwards to userspace.
>
> Improve the NMEA message receiving latency. Pass each 15-bytes chunk to
> userspace as soon as it's received.
>
> Tested-by: Miroslav Lichvar <mlichvar@...hat.com>
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_gnss.c | 29 +++++++----------------
>  drivers/net/ethernet/intel/ice/ice_gnss.h |  6 ++++-
>  2 files changed, 14 insertions(+), 21 deletions(-)

Reviewed-by: Karol Kolacinski <karol.kolacinski@...el.com>