netdev - Re: [PATCH net-next v2 1/2] net: vxlan: rename SKB_DROP_REASON_VXLAN_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2L9TFL0dWJn_D-M@shredder>
Date: Wed, 18 Dec 2024 18:50:20 +0200
From: Ido Schimmel <idosch@...sch.org>
To: Radu Rendec <rrendec@...hat.com>
Cc: Nikolay Aleksandrov <razor@...ckwall.org>,
	Roopa Prabhu <roopa@...dia.com>, bridge@...ts.linux.dev,
	netdev@...r.kernel.org, Simon Horman <horms@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next v2 1/2] net: vxlan: rename
 SKB_DROP_REASON_VXLAN_NO_REMOTE

On Tue, Dec 17, 2024 at 06:07:10PM -0500, Radu Rendec wrote:
> @@ -497,8 +497,8 @@ enum skb_drop_reason {
>  	 * entry or an entry pointing to a nexthop.
>  	 */
>  	SKB_DROP_REASON_VXLAN_ENTRY_EXISTS,
> -	/** @SKB_DROP_REASON_VXLAN_NO_REMOTE: no remote found for xmit */
> -	SKB_DROP_REASON_VXLAN_NO_REMOTE,
> +	/** @SKB_DROP_REASON_NO_TX_TARGET: no remote found for xmit */

Looks good, but I suggest replacing "remote" with "target" since
"remote" is VXLAN specific.

> +	SKB_DROP_REASON_NO_TX_TARGET,
>  	/**
>  	 * @SKB_DROP_REASON_IP_TUNNEL_ECN: skb is dropped according to
>  	 * RFC 6040 4.2, see __INET_ECN_decapsulate() for detail.
> -- 
> 2.47.1
>