netdev - [PATCH net-next v2 0/8] net: napi: add CPU affinity to napi->config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241218165843.744647-1-ahmed.zaki@intel.com>
Date: Wed, 18 Dec 2024 09:58:35 -0700
From: Ahmed Zaki <ahmed.zaki@...el.com>
To: netdev@...r.kernel.org
Cc: intel-wired-lan@...ts.osuosl.org,
	andrew+netdev@...n.ch,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com,
	davem@...emloft.net,
	michael.chan@...adcom.com,
	tariqt@...dia.com,
	anthony.l.nguyen@...el.com,
	przemyslaw.kitszel@...el.com,
	jdamato@...tly.com,
	shayd@...dia.com,
	akpm@...ux-foundation.org,
	Ahmed Zaki <ahmed.zaki@...el.com>
Subject: [PATCH net-next v2 0/8] net: napi: add CPU affinity to napi->config 

Move the IRQ affinity management to the napi struct. All drivers that are
already using netif_napi_set_irq() are modified to the new API. Except
mlx5 because it is implementing IRQ pools and moving to the new API does
not seem trivial.

Tested on bnxt, ice and idpf.
---
Opens: is cpu_online_mask the best default mask? drivers do this differently 

v2:
    - Also move the ARFS IRQ affinity management from drivers to core. Via
      netif_napi_set_irq(), drivers can ask the core to add the IRQ to the
      ARFS rmap (already allocated by the driver).

RFC -> v1:
    - https://lore.kernel.org/netdev/20241210002626.366878-1-ahmed.zaki@intel.com/
    - move static inline affinity functions to net/dev/core.c
    - add the new napi->irq_flags (patch 1)
    - add code changes to bnxt, mlx4 and ice.

Ahmed Zaki (8):
  net: napi: add irq_flags to napi struct
  net: allow ARFS rmap management in core
  lib: cpu_rmap: allow passing a notifier callback
  net: napi: add CPU affinity to napi->config
  bnxt: use napi's irq affinity
  ice: use napi's irq affinity
  idpf: use napi's irq affinity
  mlx4: use napi's irq affinity

 drivers/net/ethernet/amazon/ena/ena_netdev.c  | 21 ++---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 51 +++--------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  2 -
 drivers/net/ethernet/broadcom/tg3.c           |  2 +-
 drivers/net/ethernet/cisco/enic/enic_main.c   |  3 +-
 drivers/net/ethernet/google/gve/gve_utils.c   |  2 +-
 .../net/ethernet/hisilicon/hns3/hns3_enet.c   |  2 +-
 drivers/net/ethernet/intel/e1000/e1000_main.c |  2 +-
 drivers/net/ethernet/intel/e1000e/netdev.c    |  2 +-
 drivers/net/ethernet/intel/ice/ice.h          |  3 -
 drivers/net/ethernet/intel/ice/ice_arfs.c     | 10 +--
 drivers/net/ethernet/intel/ice/ice_base.c     |  7 +-
 drivers/net/ethernet/intel/ice/ice_lib.c      | 14 +--
 drivers/net/ethernet/intel/ice/ice_main.c     | 44 ----------
 drivers/net/ethernet/intel/idpf/idpf_txrx.c   | 19 ++--
 drivers/net/ethernet/intel/idpf/idpf_txrx.h   |  6 +-
 drivers/net/ethernet/mellanox/mlx4/en_cq.c    |  8 +-
 .../net/ethernet/mellanox/mlx4/en_netdev.c    | 33 +------
 drivers/net/ethernet/mellanox/mlx4/eq.c       | 24 +----
 drivers/net/ethernet/mellanox/mlx4/main.c     | 42 +--------
 drivers/net/ethernet/mellanox/mlx4/mlx4.h     |  1 -
 drivers/net/ethernet/mellanox/mlx4/mlx4_en.h  |  1 -
 .../net/ethernet/mellanox/mlx5/core/en_main.c |  2 +-
 .../net/ethernet/mellanox/mlx5/core/pci_irq.c |  2 +-
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.c  |  3 +-
 drivers/net/ethernet/qlogic/qede/qede_main.c  | 28 +++---
 drivers/net/ethernet/sfc/falcon/efx.c         |  9 ++
 drivers/net/ethernet/sfc/falcon/nic.c         | 10 ---
 drivers/net/ethernet/sfc/nic.c                |  2 +-
 drivers/net/ethernet/sfc/siena/efx_channels.c |  9 ++
 drivers/net/ethernet/sfc/siena/nic.c          | 10 ---
 include/linux/cpu_rmap.h                      | 13 ++-
 include/linux/netdevice.h                     | 23 ++++-
 lib/cpu_rmap.c                                | 20 ++---
 net/core/dev.c                                | 87 ++++++++++++++++++-
 35 files changed, 215 insertions(+), 302 deletions(-)

-- 
2.43.0