netdev - Re: [PATCH net-next v3 4/7] vsock/test: Adapt send_byte()/recv_byte() to handle MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <zfefs2bpzzssles47arkxu7ectqelyyuy4rahfkeksvcxc7m4f@b6owwwenivua>
Date: Wed, 18 Dec 2024 18:55:21 +0100
From: Stefano Garzarella <sgarzare@...hat.com>
To: Michal Luczaj <mhal@...x.co>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 4/7] vsock/test: Adapt
 send_byte()/recv_byte() to handle MSG_ZEROCOPY

On Wed, Dec 18, 2024 at 03:32:37PM +0100, Michal Luczaj wrote:
>For a zercopy send(), buffer (always byte 'A') needs to be preserved (thus
>it can not be on the stack) or the data recv()ed check in recv_byte() might
>fail.
>
>While there, change the printf format to 0x%02x so the '\0' bytes can be
>seen.
>
>Signed-off-by: Michal Luczaj <mhal@...x.co>
>---
> tools/testing/vsock/util.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>

>
>diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
>index 81b9a31059d8173a47ea87324da50e7aedd7308a..7058dc614c25f546fc3219d6b9ade2dcef21a9bd 100644
>--- a/tools/testing/vsock/util.c
>+++ b/tools/testing/vsock/util.c
>@@ -401,7 +401,7 @@ void recv_buf(int fd, void *buf, size_t len, int flags, ssize_t expected_ret)
>  */
> void send_byte(int fd, int expected_ret, int flags)
> {
>-	const uint8_t byte = 'A';
>+	static const uint8_t byte = 'A';
>
> 	send_buf(fd, &byte, sizeof(byte), flags, expected_ret);
> }
>@@ -420,7 +420,7 @@ void recv_byte(int fd, int expected_ret, int flags)
> 	recv_buf(fd, &byte, sizeof(byte), flags, expected_ret);
>
> 	if (byte != 'A') {
>-		fprintf(stderr, "unexpected byte read %c\n", byte);
>+		fprintf(stderr, "unexpected byte read 0x%02x\n", byte);
> 		exit(EXIT_FAILURE);
> 	}
> }
>
>-- 
>2.47.1
>