netdev - Re: [PATCH v9 1/1] mctp pcc: Implement MCTP over PCC Transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2MRouOBizgKt-h_@LQ3V64L9R2>
Date: Wed, 18 Dec 2024 10:17:06 -0800
From: Joe Damato <jdamato@...tly.com>
To: Adam Young <admiyo@...eremail.onmicrosoft.com>
Cc: admiyo@...amperecomputing.com, Jeremy Kerr <jk@...econstruct.com.au>,
	Matt Johnston <matt@...econstruct.com.au>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sudeep Holla <sudeep.holla@....com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Huisong Li <lihuisong@...wei.com>
Subject: Re: [PATCH v9 1/1] mctp pcc: Implement MCTP over PCC Transport

On Wed, Dec 18, 2024 at 11:23:06AM -0500, Adam Young wrote:
> 
> On 12/17/24 14:04, Joe Damato wrote:

[...]

> > 
> > > +		u64_stats_update_end(&dstats->syncp);
> > > +		return;
> > > +	}
> > > +	if (!skb) {
> > > +		u64_stats_inc(&dstats->rx_drops);
> > > +		u64_stats_update_end(&dstats->syncp);
> > > +		return;
> > > +	}
> > > +	u64_stats_inc(&dstats->rx_packets);
> > > +	u64_stats_add(&dstats->rx_bytes, data_len);
> > > +	u64_stats_update_end(&dstats->syncp);
> > I suspect what Jeremy meant (but please feel free to correct me if
> > I'm mistaken, Jeremy) was that you may want to use the helpers in:
> > 
> > include/linux/netdevice.h
> > 
> > e.g.
> > 
> >    dev_dstats_rx_add(mctp_pcc_ndev->mdev.dev, data_len);
> >    dev_dstats_rx_dropped(mctp_pcc_ndev->mdev.dev);
> > 
> > etc.
> 
> I don't see those function calls in the 6.13-rc3 tree I am working with. 
> Are they coming later?

If you are adding new code you should target net-next/main, which
has commit 18eabadd73ae ("vrf: Make pcpu_dstats update functions
available to other modules.") which adds those functions.

Have you rebased recently? Maybe your local clone of the tree is
stale?

FWIW: you can use `git format-patch --base=auto ...` to include base
tree information which can be helpful for identifying issues like
the above.