netdev - Re: [PATCH net v2] rust: net::phy fix module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241218115850.22cba4bc@kernel.org>
Date: Wed, 18 Dec 2024 11:58:50 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: FUJITA Tomonori <fujita.tomonori@...il.com>, davem@...emloft.net,
 edumazet@...gle.com, rust-for-linux@...r.kernel.org, andrew@...n.ch,
 hkallweit1@...il.com, tmgross@...ch.edu, aliceryhl@...gle.com,
 boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com,
 benno.lossin@...ton.me, a.hindborg@...nel.org, ojeda@...nel.org,
 alex.gaynor@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] rust: net::phy fix module autoloading

On Wed, 18 Dec 2024 11:04:25 +0100 Paolo Abeni wrote:
> >> I think I figured it out, you must have old clang. On Fedora 41
> >> CFI_CLANG defaults to y and prevents RUST from getting enabled.  
> > 
> > Still hitting a problem in module signing. 
> > Rust folks does this ring a bell?
> > 
> > make[4]: *** Deleting file 'certs/signing_key.pem'
> >   GENKEY  certs/signing_key.pem
> > ....+.........+++++
> > -----
> > 80728E46C07F0000:error:03000098:digital envelope routines:do_sigver_init:invalid digest:crypto/evp/m_sigver.c:342:
> > make[4]: *** [../certs/Makefile:53: certs/signing_key.pem] Error 1
> > make[4]: *** Waiting for unfinished jobs....
> > 
> > allmodconfig without Rust builds fine with both GCC and clang.  
> 
> FTR, I got a similar error (even without RUST) when I had
> 
> CONFIG_MODULE_SIG_HASH="sha1"
> 
> I moved to
> 
> CONFIG_MODULE_SIG_HASH="sha256"
> 
> since a while, and that fixed the issue for me (also
> CONFIG_MODULE_SIG_SHA256=y is needed).

Oh, some form of forced SHA1 deprecation in Fedora 41 possibly?
I switched to sha256 and that fixes the issue. We'll find out
if Rust is really fixed next time a Rust patch comes :)