netdev - Re: [PATCH bpf-next v5 5/5] bpf: selftests: verifier: Add nullness elision tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d05e9e36-36e4-456f-9c4a-2476be13a7f7@app.fastmail.com>
Date: Tue, 17 Dec 2024 17:57:10 -0800
From: "Daniel Xu" <dxu@...uu.xyz>
To: "Eduard Zingerman" <eddyz87@...il.com>,
 "Andrii Nakryiko" <andrii@...nel.org>, "Alexei Starovoitov" <ast@...nel.org>,
 "Shuah Khan" <shuah@...nel.org>, "Daniel Borkmann" <daniel@...earbox.net>
Cc: "Mykola Lysenko" <mykolal@...com>,
 "Martin KaFai Lau" <martin.lau@...ux.dev>, "Song Liu" <song@...nel.org>,
 "Yonghong Song" <yonghong.song@...ux.dev>,
 "John Fastabend" <john.fastabend@...il.com>, "KP Singh" <kpsingh@...nel.org>,
 "Stanislav Fomichev" <sdf@...ichev.me>, "Hao Luo" <haoluo@...gle.com>,
 "Jiri Olsa" <jolsa@...nel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v5 5/5] bpf: selftests: verifier: Add nullness elision
 tests


On Fri, Dec 13, 2024, at 10:17 PM, Eduard Zingerman wrote:
> On Thu, 2024-12-12 at 16:22 -0700, Daniel Xu wrote:
>> Test that nullness elision works for common use cases. For example, we
>> want to check that both full and subreg stack slots are recognized. As
>> well as when there's both const and non-const values of R2 leading up to
>> a lookup. And obviously some bound checks.
>> 
>> Signed-off-by: Daniel Xu <dxu@...uu.xyz>
>> ---
>
> Daniel,
>
> since there would be a respin of this patch-set,
> maybe consider using plain C for some of the tests?

Yeah, makes sense. Will do for v6.

Thanks,
Daniel