netdev - Re: [PATCH net v2] rust: net::phy fix module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241218.112442.597481561044471700.fujita.tomonori@gmail.com>
Date: Wed, 18 Dec 2024 11:24:42 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: kuba@...nel.org
Cc: pabeni@...hat.com, fujita.tomonori@...il.com, davem@...emloft.net,
 edumazet@...gle.com, rust-for-linux@...r.kernel.org, andrew@...n.ch,
 hkallweit1@...il.com, tmgross@...ch.edu, aliceryhl@...gle.com,
 boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com,
 benno.lossin@...ton.me, a.hindborg@...nel.org, ojeda@...nel.org,
 alex.gaynor@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] rust: net::phy fix module autoloading

On Tue, 17 Dec 2024 08:51:24 -0800
Jakub Kicinski <kuba@...nel.org> wrote:

> On Tue, 17 Dec 2024 07:44:00 -0800 Jakub Kicinski wrote:
>> On Tue, 17 Dec 2024 16:11:29 +0100 Paolo Abeni wrote:
>> > > I'll look into it. Just in case you already investigated the same thing
>> > > I would - have you tried the rust build script from NIPA or just to
>> > > build manually?     
>> > 
>> > I tried both (I changed the build dir in the script to fit my setup). I
>> > could not see the failure in any case - on top of RHEL 9.  
>> 
>> I think I figured it out, you must have old clang. On Fedora 41
>> CFI_CLANG defaults to y and prevents RUST from getting enabled.
> 
> Still hitting a problem in module signing. 
> Rust folks does this ring a bell?
> 
> make[4]: *** Deleting file 'certs/signing_key.pem'
>   GENKEY  certs/signing_key.pem
> ....+.........+++++
> -----
> 80728E46C07F0000:error:03000098:digital envelope routines:do_sigver_init:invalid digest:crypto/evp/m_sigver.c:342:
> make[4]: *** [../certs/Makefile:53: certs/signing_key.pem] Error 1
> make[4]: *** Waiting for unfinished jobs....

Generating a key (openssl command) failed?

> allmodconfig without Rust builds fine with both GCC and clang.
> 
> build flags: LLVM=1
> config: https://paste.centos.org/view/0555e9dd
> OS: Fedora 41

CONFIG_MODULE_SIG_HASH is same on rust build and non rust build?

Looks like it's the only kernel config option that might change the
command behavior.

I can't reproduce the error with the config on Ubuntu 24.04.