netdev - Re: [PATCH] net: stmmac: call stmmac_remove_config_dt() in error paths in stmmac_probe_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a288732f-001c-42ed-99ce-e0f6db160918@pf.is.s.u-tokyo.ac.jp>
Date: Wed, 18 Dec 2024 12:27:26 +0900
From: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: alexandre.torgue@...s.st.com, joabreu@...opsys.com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, mcoquelin.stm32@...il.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: call stmmac_remove_config_dt() in error
 paths in stmmac_probe_config_dt()



On 12/17/24 20:27, Dan Carpenter wrote:
> On Tue, Dec 17, 2024 at 12:32:43PM +0900, Joe Hattori wrote:
>> Also, remove the first argument of stmmac_remove_config_dt() as it is not
>> used.
> 
> Don't do that.  It makes the patch difficult to review.

True, the patch is now split into two in v2.

> 
> regards,
> dan carpenter
> 

Best,
Joe