netdev - Re: [PATCH v4 net-next] net/mlx5e: Report rx_discards_phy via rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adb3770d-134d-47e4-8ccf-cd2bc99060d6@gmail.com>
Date: Wed, 18 Dec 2024 08:20:45 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, saeedm@...dia.com, tariqt@...dia.com,
 gal@...dia.com
Cc: Yafang Shao <laoar.shao@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v4 net-next] net/mlx5e: Report rx_discards_phy via
 rx_dropped



On 17/12/2024 20:45, Jakub Kicinski wrote:
> On Tue, 10 Dec 2024 10:27:06 +0800 Yafang Shao wrote:
>> We noticed a high number of rx_discards_phy events on certain servers while
>> running `ethtool -S`. However, this critical counter is not currently
>> included in the standard /proc/net/dev statistics file, making it difficult
>> to monitor effectively—especially given the diversity of vendors across a
>> large fleet of servers.
>>
>> Let's report it via the standard rx_dropped metric.
> 

Reviewed-by: Tariq Toukan <tariqt@...dia.com>

> nVidia folks, could you review? Or you're just taking it via your tree
> and it will reappear on the list soon?

Please take it.

We do not work anymore with our own netdev tree.
We still work with the mlx5-next tree for patches that should be 
"shared" with non-netdev trees, mainly IFC changes.

> I want to make sure there is no
> off-list discussion with the author that leads to the patch being
> "lost"...