netdev - Re: [PATCH net-next 2/3] net: ethernet: ti: cpsw: disable PHY EEE advertisement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <270e31cf-7d91-45c1-bc3d-c5d171545fd3@lunn.ch>
Date: Thu, 19 Dec 2024 09:34:58 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Tony Lindgren <tony@...mide.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Russell King - ARM Linux <linux@...linux.org.uk>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>,
	linux-omap@...r.kernel.org,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/3] net: ethernet: ti: cpsw: disable PHY EEE
 advertisement

On Mon, Dec 16, 2024 at 10:32:25PM +0100, Heiner Kallweit wrote:
> It seems the cpsw MAC doesn't support EEE. See e.g. the commit message of
> ce2899428ec0 ("ARM: dts: am335x-baltos: disable EEE for Atheros 8035 PHY").
> There are cases where this causes issues if the PHY's on both sides have
> negotiated EEE. As a workaround EEE modes of the PHY are marked broken
> in DT, effectively disabling EEE advertisement.
> Improve this by using new function phy_disable_eee() in the MAC driver.
> This properly disables EEE advertisement, and allows to remove the
> eee-broken-xxx properties from DT. As EEE is disabled anyway, we can
> remove also the set_eee ethtool op.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew