netdev - Re: [PATCH RESEND V2 net 5/7] net: hns3: initialize reset_timer before hclgevf_misc_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a96a6923-6a48-4760-97fb-01eed3735e26@huawei.com>
Date: Thu, 19 Dec 2024 19:48:26 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <andrew+netdev@...n.ch>,
	<horms@...nel.org>, <shenjian15@...wei.com>, <wangpeiyang1@...wei.com>,
	<liuyonglong@...wei.com>, <chenhao418@...wei.com>,
	<jonathan.cameron@...wei.com>, <shameerali.kolothum.thodi@...wei.com>,
	<salil.mehta@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND V2 net 5/7] net: hns3: initialize reset_timer
 before hclgevf_misc_irq_init()


on 2024/12/18 17:20, Michal Swiatkowski wrote:
> On Tue, Dec 17, 2024 at 09:08:37AM +0800, Jijie Shao wrote:
>> From: Jian Shen <shenjian15@...wei.com>
>>
>> Currently the misc irq is initialized before reset_timer setup. But
>> it will access the reset_timer in the irq handler. So initialize
>> the reset_timer earlier.
>>
>> Fixes: ff200099d271 ("net: hns3: remove unnecessary work in hclgevf_main")
>> Signed-off-by: Jian Shen <shenjian15@...wei.com>
>> Signed-off-by: Jijie Shao <shaojijie@...wei.com>
>> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
>> ---
>>   drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
>> index fd0abe37fdd7..8739da317897 100644
>> --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
>> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
>> @@ -2313,6 +2313,7 @@ static void hclgevf_state_init(struct hclgevf_dev *hdev)
>>   	clear_bit(HCLGEVF_STATE_RST_FAIL, &hdev->state);
>>   
>>   	INIT_DELAYED_WORK(&hdev->service_task, hclgevf_service_task);
> Comment here that timer needs to be initialized before misc irq will be
> nice, but that is onlu my impression.


I'll add a comment in the next version.

Thanks,
Jijie Shao

>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
>
> Thanks
>> +	timer_setup(&hdev->reset_timer, hclgevf_reset_timer, 0);
>>   
>>   	mutex_init(&hdev->mbx_resp.mbx_mutex);
>>   	sema_init(&hdev->reset_sem, 1);
>> @@ -3012,7 +3013,6 @@ static int hclgevf_init_hdev(struct hclgevf_dev *hdev)
>>   		 HCLGEVF_DRIVER_NAME);
>>   
>>   	hclgevf_task_schedule(hdev, round_jiffies_relative(HZ));
>> -	timer_setup(&hdev->reset_timer, hclgevf_reset_timer, 0);
>>   
>>   	return 0;
>>   
>> -- 
>> 2.33.0