netdev - Re: [PATCH net-next v2 4/4] net: hisilicon: hns: Remove unused enums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa410af0-e4b0-4199-8f2a-960399e54d82@huawei.com>
Date: Thu, 19 Dec 2024 20:30:01 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: <linux@...blig.org>, <salil.mehta@...wei.com>, <shenjian15@...wei.com>,
	<andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>
CC: <shaojijie@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 4/4] net: hisilicon: hns: Remove unused enums


on 2024/12/19 0:33, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> The enums dsaf_roce_port_mode, dsaf_roce_port_num and dsaf_roce_qos_sl
> are unused after the removal of the reset code.
>
> Remove them.

Thanks,

Reviewed-by: Jijie Shao<shaojijie@...wei.com>


>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>   .../ethernet/hisilicon/hns/hns_dsaf_main.h    | 23 -------------------
>   1 file changed, 23 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
> index bb8267aafc43..653dfbb25d1b 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
> @@ -42,29 +42,6 @@ struct hns_mac_cb;
>   
>   #define HNS_MAX_WAIT_CNT 10000
>   
> -enum dsaf_roce_port_mode {
> -	DSAF_ROCE_6PORT_MODE,
> -	DSAF_ROCE_4PORT_MODE,
> -	DSAF_ROCE_2PORT_MODE,
> -	DSAF_ROCE_CHAN_MODE_NUM,
> -};
> -
> -enum dsaf_roce_port_num {
> -	DSAF_ROCE_PORT_0,
> -	DSAF_ROCE_PORT_1,
> -	DSAF_ROCE_PORT_2,
> -	DSAF_ROCE_PORT_3,
> -	DSAF_ROCE_PORT_4,
> -	DSAF_ROCE_PORT_5,
> -};
> -
> -enum dsaf_roce_qos_sl {
> -	DSAF_ROCE_SL_0,
> -	DSAF_ROCE_SL_1,
> -	DSAF_ROCE_SL_2,
> -	DSAF_ROCE_SL_3,
> -};
> -
>   #define DSAF_STATS_READ(p, offset) (*((u64 *)((u8 *)(p) + (offset))))
>   #define HNS_DSAF_IS_DEBUG(dev) ((dev)->dsaf_mode == DSAF_MODE_DISABLE_SP)
>