[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANn89iL6uwSyb077XE5HNwqm62et-7D58yEZOSxi0hDKMk-FjA@mail.gmail.com>
Date: Thu, 19 Dec 2024 14:28:12 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com,
jdamato@...tly.com, almasrymina@...gle.com, sridhar.samudrala@...el.com,
amritha.nambiar@...el.com
Subject: Re: [PATCH net v2 1/2] netdev-genl: avoid empty messages in napi get
On Thu, Dec 19, 2024 at 4:28 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Empty netlink responses from do() are not correct (as opposed to
> dump() where not dumping anything is perfectly fine).
> We should return an error if the target object does not exist,
> in this case if the netdev is down we "hide" the NAPI instances.
>
> Fixes: 27f91aaf49b3 ("netdev-genl: Add netlink framework functions for napi")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
Reviewed-by: Eric Dumazet <edumazet@...gle.com>
Powered by blists - more mailing lists