netdev - Re: [PATCH net] net: dsa: restore dsa_software_vlan_untag() ability to operate on VLAN-untagged traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241219150743.rhw2nv3fysplysrf@skbuf>
Date: Thu, 19 Dec 2024 17:07:43 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: robert.hodaszi@...i.com
Cc: patchwork-bot+netdevbpf@...nel.org, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew@...n.ch, claudiu.manoil@....com,
	alexandre.belloni@...tlin.com, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net] net: dsa: restore dsa_software_vlan_untag() ability
 to operate on VLAN-untagged traffic

On Thu, Dec 19, 2024 at 03:30:31AM +0000, patchwork-bot+netdevbpf@...nel.org wrote:
> Hello:
> 
> This patch was applied to netdev/net.git (main)
> by Jakub Kicinski <kuba@...nel.org>:
> 
> On Mon, 16 Dec 2024 15:50:59 +0200 you wrote:
> > Robert Hodaszi reports that locally terminated traffic towards
> > VLAN-unaware bridge ports is broken with ocelot-8021q. He is describing
> > the same symptoms as for commit 1f9fc48fd302 ("net: dsa: sja1105: fix
> > reception from VLAN-unaware bridges").
> > 
> > For context, the set merged as "VLAN fixes for Ocelot driver":
> > https://lore.kernel.org/netdev/20240815000707.2006121-1-vladimir.oltean@nxp.com/
> > 
> > [...]
> 
> Here is the summary with links:
>   - [net] net: dsa: restore dsa_software_vlan_untag() ability to operate on VLAN-untagged traffic
>     https://git.kernel.org/netdev/net/c/16f027cd40ee
> 
> You are awesome, thank you!
> -- 
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
> 
>

This is on me, sorry. I should have marked this patch as "changes requested",
(https://lore.kernel.org/netdev/49d10bde-6257-4cc0-abaf-3bffb3a812c0@digi.com/)
but I had other urgent priorities. I will send the requested removal of
the duplicate br_vlan_get_proto() calls in net-next once the main branch
gets reintegrated into it.

To Robert, and not meant as an accusation at all, because I could have
done something about it too, earlier: when you have comments for an
already-posted patch, please make them _on that patch_ and not somewhere else.