netdev - Re: [PATCH net-next v6 3/9] bnxt_en: add support for tcp-data-split ethtool command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTUToUPUceEFd0Xh_JL8kVZOX=rTarpy1iOAD5KvRWP5Fg@mail.gmail.com>
Date: Fri, 20 Dec 2024 00:14:01 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com, 
	almasrymina@...gle.com, donald.hunter@...il.com, corbet@....net, 
	michael.chan@...adcom.com, andrew+netdev@...n.ch, hawk@...nel.org, 
	ilias.apalodimas@...aro.org, ast@...nel.org, daniel@...earbox.net, 
	john.fastabend@...il.com, dw@...idwei.uk, sdf@...ichev.me, 
	asml.silence@...il.com, brett.creeley@....com, linux-doc@...r.kernel.org, 
	netdev@...r.kernel.org, kory.maincent@...tlin.com, 
	maxime.chevallier@...tlin.com, danieller@...dia.com, hengqi@...ux.alibaba.com, 
	ecree.xilinx@...il.com, przemyslaw.kitszel@...el.com, hkallweit1@...il.com, 
	ahmed.zaki@...el.com, rrameshbabu@...dia.com, idosch@...dia.com, 
	jiri@...nulli.us, bigeasy@...utronix.de, lorenzo@...nel.org, 
	jdamato@...tly.com, aleksander.lobakin@...el.com, kaiyuanz@...gle.com, 
	willemb@...gle.com, daniel.zahka@...il.com, 
	Andy Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next v6 3/9] bnxt_en: add support for tcp-data-split
 ethtool command

On Thu, Dec 19, 2024 at 11:29 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 19 Dec 2024 23:05:30 +0900 Taehee Yoo wrote:
> > > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
> > > > index f88b641533fc..1bfff7f29310 100644
> > > > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
> > > > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
> > > > @@ -395,6 +395,10 @@ static int bnxt_xdp_set(struct bnxt *bp, struct bpf_prog *prog)
> > > >                           bp->dev->mtu, BNXT_MAX_PAGE_MODE_MTU);
> > > >               return -EOPNOTSUPP;
> > > >       }
> > > > +     if (prog && bp->flags & BNXT_FLAG_HDS) {
> > > > +             netdev_warn(dev, "XDP is disallowed when HDS is enabled.\n");
> > > > +             return -EOPNOTSUPP;
> > > > +     }
> > >
> > > And this check should also live in the core, now that core has access
> > > to dev->ethtool->hds_config ? I think you can add this check to the
> > > core in the same patch as the chunk referred to above.
> >
> > The bnxt_en disallows setting up both single and multi buffer XDP, but core
> > checks only single buffer XDP. So, if multi buffer XDP is attaching to
> > the bnxt_en driver when HDS is enabled, the core can't filter it.
>
> Hm. Did you find this in the code, or did Broadcom folks suggest it?
> AFAICT bnxt supports multi-buf XDP. Is there something in the code
> that special-cases aggregation but doesn't work for pure HDS?

There were some comments about HDS with XDP in the following thread.
https://lore.kernel.org/netdev/20241022162359.2713094-1-ap420073@gmail.com/T/
I may misunderstand reviews from Broadcom folks.