netdev - Re: [PATCH net-next] netlink: correct nlmsg size for multicast notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADXeF1FVRY4t7L-J16FDu_6SvuvU3_jKJQo3+kFyDR7s_92kAg@mail.gmail.com>
Date: Fri, 20 Dec 2024 01:13:21 +0900
From: Yuyang Huang <yuyanghuang@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, David Ahern <dsahern@...nel.org>, 
	roopa@...ulusnetworks.com, jiri@...nulli.us, stephen@...workplumber.org, 
	jimictw@...gle.com, prohr@...gle.com, liuhangbin@...il.com, 
	nicolas.dichtel@...nd.com, andrew@...n.ch, pruddy@...tta.att-mail.com, 
	netdev@...r.kernel.org, Maciej Żenczykowski <maze@...gle.com>, 
	Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH net-next] netlink: correct nlmsg size for multicast notifications

Thank you very much for the detailed explanation.

I will change GFP_ATOMIC to GFP_KERNEL in the v2 patch.

Thanks,
Yuyang

On Fri, Dec 20, 2024 at 12:53 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Thu, Dec 19, 2024 at 4:35 PM Yuyang Huang <yuyanghuang@...gle.com> wrote:
> >
> > >Same remark for inet_ifmcaddr_notify()
> >
> > Moreover, for both IPv4 and IPv6, when a device is up, the kernel
> > joins the all-hosts multicast addresses (224.0.0.1/ff02::1). I guess
> > this logic also does not run in process context?
> >
>
> Hopefully all these paths are stressed in kselftest.
>
> A wrong gfp would trigger issues when you run the selftests before
> submission, or in netdev CI.