netdev - RE: [Intel-wired-lan] [PATCH iwl-net v2] ice: fix incorrect PHY settings for 100 GB/s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB62418B1498A80CDB1BC3EDB88B062@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Thu, 19 Dec 2024 16:32:18 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: "Korba, Przemyslaw" <przemyslaw.korba@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "richardcochran@...il.com"
	<richardcochran@...il.com>, "andrew@...n.ch" <andrew@...n.ch>,
	"olteanv@...il.com" <olteanv@...il.com>, "Olech, Milena"
	<milena.olech@...el.com>, "pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>,
	"Korba, Przemyslaw" <przemyslaw.korba@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v2] ice: fix incorrect PHY
 settings for 100 GB/s

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Przemyslaw Korba
> Sent: 04 December 2024 18:52
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; richardcochran@...il.com; andrew@...n.ch; olteanv@...il.com; Olech, Milena <milena.olech@...el.com>; pmenzel@...gen.mpg.de; Korba, Przemyslaw <przemyslaw.korba@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net v2] ice: fix incorrect PHY settings for 100 GB/s
>
> ptp4l application reports too high offset when ran on E823 device with a 100GB/s link. Those values cannot go under 100ns, like in a working case when using 100 GB/s cable.
> 
> This is due to incorrect frequency settings on the PHY clocks for
> 100 GB/s speed. Changes are introduced to align with the internal hardware documentation, and correctly initialize frequency in PHY clocks with the frequency values that are in our HW spec.
>
> To reproduce the issue run ptp4l as a Time Receiver on E823 device, and observe the offset, which will never approach values seen in the PTP working case.
>
> Reproduction output:
> ptp4l -i enp137s0f3 -m -2 -s -f /etc/ptp4l_8275.conf
> ptp4l[5278.775]: master offset      12470 s2 freq  +41288 path delay -3002
> ptp4l[5278.837]: master offset      10525 s2 freq  +39202 path delay -3002
> ptp4l[5278.900]: master offset     -24840 s2 freq  -20130 path delay -3002
> ptp4l[5278.963]: master offset      10597 s2 freq  +37908 path delay -3002
> ptp4l[5279.025]: master offset       8883 s2 freq  +36031 path delay -3002
> ptp4l[5279.088]: master offset       7267 s2 freq  +34151 path delay -3002
> ptp4l[5279.150]: master offset       5771 s2 freq  +32316 path delay -3002
> ptp4l[5279.213]: master offset       4388 s2 freq  +30526 path delay -3002
> ptp4l[5279.275]: master offset     -30434 s2 freq  -28485 path delay -3002
> ptp4l[5279.338]: master offset     -28041 s2 freq  -27412 path delay -3002
> ptp4l[5279.400]: master offset       7870 s2 freq  +31118 path delay -3002
>
> Fixes: 3a7496234d17 ("ice: implement basic E822 PTP support")
> Reviewed-by: Milena Olech <milena.olech@...el.com>
> Signed-off-by: Przemyslaw Korba <przemyslaw.korba@...el.com>
> ---
> Changelog:
> v2:
> change commit message
> v1:
> https://lore.kernel.org/intel-wired-lan/20241126102311.344972-1-przemyslaw.korba@intel.com/
> ---
> drivers/net/ethernet/intel/ice/ice_ptp_consts.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)