netdev - Re: [PATCH net-next v2] net: mdio_bus: change the bus name to mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40cbb576-edd9-40c1-8f7a-8dd6dfa5d7ed@gmail.com>
Date: Thu, 19 Dec 2024 08:52:04 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Andrew Lunn <andrew@...n.ch>, Yajun Deng <yajun.deng@...ux.dev>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: mdio_bus: change the bus name to mdio

On 12/19/24 02:20, Andrew Lunn wrote:
> On Thu, Dec 19, 2024 at 06:04:54PM +0800, Yajun Deng wrote:
>> Since all directories under the /sys/bus are bus, we don't need to add a
>> bus suffix to mdio.
>>
>> This is the only one directory with the bus suffix, sysfs-bus-mdio is
>> now a testing ABI, and didn't have Users in it. This is the time to change
>> it before it's moved to the stable ABI.
> 
> So are you saying nobody has udev scripts referencing MDIO devices?
> Nobody has scripts accessing the statistics? You don't expect anything
> in userspace to break because of this change?
> 
> I personally think it is too late to change this, something will break
> and somebody will report a regression.

It is too late, merging this patch would be breaking ABI and that is not 
acceptable.
-- 
Florian