netdev - Re: [PATCH v3 net-next] sfc: Use netdev refcount tracking in struct efx_async_filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKRZsuOkQK-b3hr2fp0S1ivDvws4RRLUykkXhsWFLuNhw@mail.gmail.com>
Date: Thu, 19 Dec 2024 19:04:51 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: YiFei Zhu <zhuyifei@...gle.com>
Cc: Edward Cree <ecree.xilinx@...il.com>, Martin Habets <habetsm.xilinx@...il.com>, 
	netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	linux-net-drivers@....com, Willem de Bruijn <willemb@...gle.com>, 
	Mina Almasry <almasrymina@...gle.com>
Subject: Re: [PATCH v3 net-next] sfc: Use netdev refcount tracking in struct efx_async_filter_insertion

On Thu, Dec 19, 2024 at 6:30 PM YiFei Zhu <zhuyifei@...gle.com> wrote:
>
> I was debugging some netdev refcount issues in OpenOnload, and one
> of the places I was looking at was in the sfc driver. Only
> struct efx_async_filter_insertion was not using netdev refcount tracker,
> so add it here. GFP_ATOMIC because this code path is called by
> ndo_rx_flow_steer which holds RCU.
>
> This patch should be a no-op if !CONFIG_NET_DEV_REFCNT_TRACKER
>
> Signed-off-by: YiFei Zhu <zhuyifei@...gle.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !