netdev - Re: [PATCH net 2/2] can: m_can: fix missed interrupts with m_can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241218175108.39f6f79e@kernel.org>
Date: Wed, 18 Dec 2024 17:51:08 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: netdev@...r.kernel.org, davem@...emloft.net, linux-can@...r.kernel.org,
 kernel@...gutronix.de, Matthias Schiffer
 <matthias.schiffer@...tq-group.com>, Markus Schneider-Pargmann
 <msp@...libre.com>
Subject: Re: [PATCH net 2/2] can: m_can: fix missed interrupts with
 m_can_pci

On Wed, 18 Dec 2024 13:10:28 +0100 Marc Kleine-Budde wrote:
> +	while ((ir_read = m_can_read(cdev, M_CAN_IR)) != 0) {
> +		ir |= ir_read;
> +
> +		/* ACK all irqs */
> +		m_can_write(cdev, M_CAN_IR, ir);

Perhaps consider adding a cap on how many times this can loop 
as a follow up? Maybe if the HW is bad all bets are off, anyway,
but potential infinite loop inside an IRQ feels a little scary.