netdev - Re: [PATCH net-next v6 1/9] bnxt_en: add support for rx-copybreak ethtool command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241218180747.1ff69015@kernel.org>
Date: Wed, 18 Dec 2024 18:07:47 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Taehee Yoo <ap420073@...il.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 almasrymina@...gle.com, donald.hunter@...il.com, corbet@....net,
 michael.chan@...adcom.com, andrew+netdev@...n.ch, hawk@...nel.org,
 ilias.apalodimas@...aro.org, ast@...nel.org, daniel@...earbox.net,
 john.fastabend@...il.com, dw@...idwei.uk, sdf@...ichev.me,
 asml.silence@...il.com, brett.creeley@....com, linux-doc@...r.kernel.org,
 netdev@...r.kernel.org, kory.maincent@...tlin.com,
 maxime.chevallier@...tlin.com, danieller@...dia.com,
 hengqi@...ux.alibaba.com, ecree.xilinx@...il.com,
 przemyslaw.kitszel@...el.com, hkallweit1@...il.com, ahmed.zaki@...el.com,
 rrameshbabu@...dia.com, idosch@...dia.com, jiri@...nulli.us,
 bigeasy@...utronix.de, lorenzo@...nel.org, jdamato@...tly.com,
 aleksander.lobakin@...el.com, kaiyuanz@...gle.com, willemb@...gle.com,
 daniel.zahka@...il.com, Andy Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next v6 1/9] bnxt_en: add support for rx-copybreak
 ethtool command

On Wed, 18 Dec 2024 14:45:22 +0000 Taehee Yoo wrote:
> +			if (netif_running(dev)) {
> +				bnxt_close_nic(bp, false, false);
> +				bp->rx_copybreak = rx_copybreak;
> +				bnxt_set_ring_params(bp);
> +				bnxt_open_nic(bp, false, false);

We really shouldn't allow this any more, we've been rejecting
patches which try to accept reconfiguration requests by taking
the entire NIC down, without any solid recovery if memory allocation
fails.

Let's return -EBUSY if interface is running.