netdev - Re: [PATCH net-next 10/10] eth: fbnic: support ring channel set while up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241220061010.2771d19e@kernel.org>
Date: Fri, 20 Dec 2024 06:10:10 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <davem@...emloft.net>
Subject: Re: [PATCH net-next 10/10] eth: fbnic: support ring channel set
 while up

On Fri, 20 Dec 2024 14:49:02 +0100 Przemek Kitszel wrote:
> > +	fbnic_clone_swap_cfg(orig, clone);
> > +
> > +	for (i = 0; i < ARRAY_SIZE(orig->napi); i++)
> > +		swap(clone->napi[i], orig->napi[i]);
> > +	for (i = 0; i < ARRAY_SIZE(orig->tx); i++)
> > +		swap(clone->tx[i], orig->tx[i]);
> > +	for (i = 0; i < ARRAY_SIZE(orig->rx); i++)
> > +		swap(clone->rx[i], orig->rx[i]);  
> 
> I would perhaps move the above 6 lines to fbnic_clone_swap_cfg()

Hm, it's here because of how we implemented ringparam changes.
They reuse some of the clone stuff but not all. Can we revisit
once that's sent?