netdev - Re: [PATCH net-next] devlink: Improve the port attributes description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea9eda77-7c94-4342-aca6-1a4fc3446cc6@intel.com>
Date: Fri, 20 Dec 2024 09:13:23 -0800
From: "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
To: Parav Pandit <parav@...dia.com>, <netdev@...r.kernel.org>
CC: <jiri@...nulli.us>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <horms@...nel.org>, Shay Drory
	<shayd@...dia.com>, Mark Bloch <mbloch@...dia.com>, Jiri Pirko
	<jiri@...dia.com>
Subject: Re: [PATCH net-next] devlink: Improve the port attributes description



On 12/19/2024 7:01 AM, Parav Pandit wrote:
> Improve the description of devlink port attributes PF, VF and SF
> numbers.
> 
> Reviewed-by: Shay Drory <shayd@...dia.com>
> Reviewed-by: Mark Bloch <mbloch@...dia.com>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>
> Signed-off-by: Parav Pandit <parav@...dia.com>

Reviewed-by: Sridhar Samudrala <sridhar.samudrala@...el.com>

> ---
>   include/net/devlink.h | 11 ++++++-----
>   net/devlink/port.c    | 11 ++++++-----
>   2 files changed, 12 insertions(+), 10 deletions(-)
> 
> diff --git a/include/net/devlink.h b/include/net/devlink.h
> index fbb9a2668e24..a1fd37dcdc73 100644
> --- a/include/net/devlink.h
> +++ b/include/net/devlink.h
> @@ -35,7 +35,7 @@ struct devlink_port_phys_attrs {
>   /**
>    * struct devlink_port_pci_pf_attrs - devlink port's PCI PF attributes
>    * @controller: Associated controller number
> - * @pf: Associated PCI PF number for this port.
> + * @pf: associated PCI function number for the devlink port instance
>    * @external: when set, indicates if a port is for an external controller
>    */
>   struct devlink_port_pci_pf_attrs {
> @@ -47,8 +47,9 @@ struct devlink_port_pci_pf_attrs {
>   /**
>    * struct devlink_port_pci_vf_attrs - devlink port's PCI VF attributes
>    * @controller: Associated controller number
> - * @pf: Associated PCI PF number for this port.
> - * @vf: Associated PCI VF for of the PCI PF for this port.
> + * @pf: associated PCI function number for the devlink port instance
> + * @vf: associated PCI VF number of a PF for the devlink port instance;
> + *	VF number starts from 0 for the first PCI virtual function
>    * @external: when set, indicates if a port is for an external controller
>    */
>   struct devlink_port_pci_vf_attrs {
> @@ -61,8 +62,8 @@ struct devlink_port_pci_vf_attrs {
>   /**
>    * struct devlink_port_pci_sf_attrs - devlink port's PCI SF attributes
>    * @controller: Associated controller number
> - * @sf: Associated PCI SF for of the PCI PF for this port.
> - * @pf: Associated PCI PF number for this port.
> + * @sf: associated SF number of a PF for the devlink port instance
> + * @pf: associated PCI function number for the devlink port instance
>    * @external: when set, indicates if a port is for an external controller
>    */
>   struct devlink_port_pci_sf_attrs {
> diff --git a/net/devlink/port.c b/net/devlink/port.c
> index be9158b4453c..939081a0e615 100644
> --- a/net/devlink/port.c
> +++ b/net/devlink/port.c
> @@ -1376,7 +1376,7 @@ EXPORT_SYMBOL_GPL(devlink_port_attrs_set);
>    *
>    *	@devlink_port: devlink port
>    *	@controller: associated controller number for the devlink port instance
> - *	@pf: associated PF for the devlink port instance
> + *	@pf: associated PCI function number for the devlink port instance
>    *	@external: indicates if the port is for an external controller
>    */
>   void devlink_port_attrs_pci_pf_set(struct devlink_port *devlink_port, u32 controller,
> @@ -1402,8 +1402,9 @@ EXPORT_SYMBOL_GPL(devlink_port_attrs_pci_pf_set);
>    *
>    *	@devlink_port: devlink port
>    *	@controller: associated controller number for the devlink port instance
> - *	@pf: associated PF for the devlink port instance
> - *	@vf: associated VF of a PF for the devlink port instance
> + *	@pf: associated PCI function number for the devlink port instance
> + *	@vf: associated PCI VF number of a PF for the devlink port instance;
> + *	     VF number starts from 0 for the first PCI virtual function
>    *	@external: indicates if the port is for an external controller
>    */
>   void devlink_port_attrs_pci_vf_set(struct devlink_port *devlink_port, u32 controller,
> @@ -1430,8 +1431,8 @@ EXPORT_SYMBOL_GPL(devlink_port_attrs_pci_vf_set);
>    *
>    *	@devlink_port: devlink port
>    *	@controller: associated controller number for the devlink port instance
> - *	@pf: associated PF for the devlink port instance
> - *	@sf: associated SF of a PF for the devlink port instance
> + *	@pf: associated PCI function number for the devlink port instance
> + *	@sf: associated SF number of a PF for the devlink port instance
>    *	@external: indicates if the port is for an external controller
>    */
>   void devlink_port_attrs_pci_sf_set(struct devlink_port *devlink_port, u32 controller,