netdev - Re: [PATCH net-next v4 01/12] inet: homa: define user-visible API for Homa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXJAmyaF2UYH1ySR8uaV8WGPQR15G_R1WWOcUhk7N0Zfd+Vuw@mail.gmail.com>
Date: Fri, 20 Dec 2024 09:25:38 -0800
From: John Ousterhout <ouster@...stanford.edu>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, 
	Jakub Kicinski <kuba@...nel.org>, edumazet@...gle.com, horms@...nel.org
Subject: Re: [PATCH net-next v4 01/12] inet: homa: define user-visible API for Homa

On Thu, Dec 19, 2024 at 2:06 PM Przemek Kitszel
<przemyslaw.kitszel@...el.com> wrote:
>
> On 12/19/24 19:57, John Ousterhout wrote:
> > On Wed, Dec 18, 2024 at 5:43 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >>
> >> On Mon, 16 Dec 2024 16:06:14 -0800 John Ousterhout wrote:
>
>
> >>> +#ifdef __cplusplus
> >>> +}
> >>> +#endif
> >> --
> >> pw-bot: cr
> >
> > I'm not sure what "pw-bot: cr" means; I assume this is related to the
> > "#ifdef __cplusplus" discussion above?
>
> it's a shortcut for:
> Patchwork Bot, please mark that as "ChangesRequested" [by Maintainer]
>
> C++ program could simply wrap all includes by extern "C" section
>
> not sure what is better, but there is very little precedence for any
> courtesy for C++ in the kernel ATM

I have now removed the 'extern "C"' from homa.h and moved it to all of
the programs that #include it.

-John-