netdev - Re: [PATCH net-next v3 5/7] net: tn40xx: create software node for mdio and phy and add to mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33fbefb0-8b4f-4429-95a9-180b658e7914@gmx.net>
Date: Fri, 20 Dec 2024 18:48:54 +0100
From: Hans-Frieder Vogt <hfdevel@....net>
To: FUJITA Tomonori <fujita.tomonori@...il.com>,
 devnull+hfdevel.gmx.net@...nel.org
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, andrew+netdev@...n.ch, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 5/7] net: tn40xx: create software node for
 mdio and phy and add to mdiobus

On 20.12.2024 02.24, FUJITA Tomonori wrote:
> On Tue, 17 Dec 2024 22:07:36 +0100
> Hans-Frieder Vogt via B4 Relay <devnull+hfdevel.gmx.net@...nel.org> wrote:
>
>> From: Hans-Frieder Vogt <hfdevel@....net>
>>
>> Create a software node for the mdio function, with a child node for the
>> Aquantia AQR105 PHY, providing a firmware-name (and a bit more, which may
>> be used for future checks) to allow the PHY to load a MAC specific
>> firmware from the file system.
>>
>> The name of the PHY software node follows the naming convention suggested
>> in the patch for the mdiobus_scan function (in the same patch series).
>>
>> Signed-off-by: Hans-Frieder Vogt <hfdevel@....net>
>> ---
>>   drivers/net/ethernet/tehuti/tn40.c      | 10 ++++-
>>   drivers/net/ethernet/tehuti/tn40.h      | 30 +++++++++++++++
>>   drivers/net/ethernet/tehuti/tn40_mdio.c | 65 ++++++++++++++++++++++++++++++++-
>>   3 files changed, 103 insertions(+), 2 deletions(-)
> Boards with QT2025 also creates a software node for AQR105 PHY?
Yes, that's the idea. Of course, creation of the software node could be made
dependent on the actual device, but creating it unconditionally just makes
things a bit easier.
Would you rather prefer to have the software node only created for a device
that is likely to need it?