netdev - Re: [PATCH net-next v3 4/5] net: pcs: qcom-ipq9574: Add USXGMII interface mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241220134941.370d3357@kernel.org>
Date: Fri, 20 Dec 2024 13:49:41 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Lei Wei <quic_leiwei@...cinc.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Andrew Lunn
 <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, <netdev@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-arm-msm@...r.kernel.org>, <quic_kkumarcs@...cinc.com>,
 <quic_suruchia@...cinc.com>, <quic_pavir@...cinc.com>,
 <quic_linchen@...cinc.com>, <quic_luoj@...cinc.com>,
 <srinivas.kandagatla@...aro.org>, <bartosz.golaszewski@...aro.org>,
 <vsmuthu@....qualcomm.com>, <john@...ozen.org>
Subject: Re: [PATCH net-next v3 4/5] net: pcs: qcom-ipq9574: Add USXGMII
 interface mode support

On Mon, 16 Dec 2024 21:40:26 +0800 Lei Wei wrote:
> +static int ipq_pcs_config_usxgmii(struct ipq_pcs *qpcs)
> +{
> +	int ret;
> +
> +	/* Configure the XPCS for USXGMII mode if required */
> +	if (qpcs->interface != PHY_INTERFACE_MODE_USXGMII) {

nit:

	if (qpcs->interface == PHY_INTERFACE_MODE_USXGMII)
		return 0;

And then the entire function doesn't have to be indented.

Please fix this and repost, it'd be great to get a review tag from
Russell or someone with more phylink knowledge.. Please be mindful of:
https://lore.kernel.org/all/20241211164022.6a075d3a@kernel.org/
-- 
pw-bot: cr