netdev - Re: [PATCH net-next v9 03/20] net: generalise net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241220141436.65513ff7@kernel.org>
Date: Fri, 20 Dec 2024 14:14:36 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: David Wei <dw@...idwei.uk>
Cc: io-uring@...r.kernel.org, netdev@...r.kernel.org, Jens Axboe
 <axboe@...nel.dk>, Pavel Begunkov <asml.silence@...il.com>, Paolo Abeni
 <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jesper Dangaard Brouer <hawk@...nel.org>, David
 Ahern <dsahern@...nel.org>, Mina Almasry <almasrymina@...gle.com>,
 Stanislav Fomichev <stfomichev@...il.com>, Joe Damato <jdamato@...tly.com>,
 Pedro Tammela <pctammela@...atatu.com>
Subject: Re: [PATCH net-next v9 03/20] net: generalise net_iov chunk owners

On Tue, 17 Dec 2024 16:37:29 -0800 David Wei wrote:
>  struct dmabuf_genpool_chunk_owner {
> -	/* Offset into the dma-buf where this chunk starts.  */
> -	unsigned long base_virtual;
> +	struct net_iov_area area;
> +	struct net_devmem_dmabuf_binding *binding;
>  
>  	/* dma_addr of the start of the chunk.  */
>  	dma_addr_t base_dma_addr;

Is there a good reason why dma addr is not part of net_iov_area?
net_iov_area is one chunk of continuous address space.
Instead of looping over pages in io_zcrx_map_area we could map 
the whole thing in one go.