netdev - Re: [PATCH net-next v3 6/7] net: tn40xx: prepare tn40xx driver to find phy of the TN9510 card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241220.095712.813534337789962014.fujita.tomonori@gmail.com>
Date: Fri, 20 Dec 2024 09:57:12 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: hfdevel@....net, devnull+hfdevel.gmx.net@...nel.org
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, fujita.tomonori@...il.com, andrew+netdev@...n.ch,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 6/7] net: tn40xx: prepare tn40xx driver to
 find phy of the TN9510 card

On Tue, 17 Dec 2024 22:07:37 +0100
Hans-Frieder Vogt via B4 Relay <devnull+hfdevel.gmx.net@...nel.org> wrote:

> From: Hans-Frieder Vogt <hfdevel@....net>
> 
> Prepare the tn40xx driver to load for Tehuti TN9510 cards, which require
> bit 3 in the register TN40_REG_MDIO_CMD_STAT to be set. The function of bit
> 3 is unclear, but may have something to do with the length of the preamble
> in the MDIO communication. If bit 3 is not set, the PHY will not be found
> when performing a scan for PHYs. Use the available tn40_mdio_set_speed
> function which includes setting bit 3. Just move the function to before the
> devm_mdio_register function, which scans the mdio bus for PHYs.
> 
> Signed-off-by: Hans-Frieder Vogt <hfdevel@....net>
> ---
>  drivers/net/ethernet/tehuti/tn40_mdio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I confirmed that this also works for TN9310 card with QT2025 PHY.

Reviewed-by: FUJITA Tomonori <fujita.tomonori@...il.com>