netdev - Re: [PATCH v1 13/16] net-next/yunsilicon: Add eth rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <e61a710a-ea89-4c23-b720-cc91f917a162@yunsilicon.com>
Date: Fri, 20 Dec 2024 15:31:09 +0800
From: "tianx" <tianx@...silicon.com>
To: "Andrew Lunn" <andrew@...n.ch>
Cc: <netdev@...r.kernel.org>, <andrew+netdev@...n.ch>, <kuba@...nel.org>, 
	<pabeni@...hat.com>, <edumazet@...gle.com>, <davem@...emloft.net>, 
	<jeff.johnson@....qualcomm.com>, <przemyslaw.kitszel@...el.com>, 
	<weihg@...silicon.com>, <wanry@...silicon.com>
Subject: Re: [PATCH v1 13/16] net-next/yunsilicon: Add eth rx

Thank you for your suggestion. I will address this issue in the next 
version and avoid using inline functions in the .c files.


On 2024/12/19 3:47, Andrew Lunn wrote:
>> +++ b/drivers/net/ethernet/yunsilicon/xsc/net/xsc_eth_rx.c
>> @@ -33,10 +33,572 @@
>>    * SOFTWARE.
>>    */
>>   
>> +#include <linux/net_tstamp.h>
>> +#include "xsc_eth.h"
>>   #include "xsc_eth_txrx.h"
>> +#include "xsc_eth_common.h"
>> +#include <linux/device.h>
>> +#include "common/xsc_pp.h"
>> +#include "xsc_pph.h"
>> +
>> +#define PAGE_REF_ELEV  (U16_MAX)
>> +/* Upper bound on number of packets that share a single page */
>> +#define PAGE_REF_THRSD (PAGE_SIZE / 64)
>> +
>> +static inline void xsc_rq_notify_hw(struct xsc_rq *rq)
>> +{
> Please don't use inline functions in .c files. Let the compiler
> decide.
>
> 	Andrew