netdev - Re: [PATCH net-next v9 08/20] net: expose page_pool_{set,clear}_pp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241220182304.59753594@kernel.org>
Date: Fri, 20 Dec 2024 18:23:04 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Pavel Begunkov <asml.silence@...il.com>
Cc: David Wei <dw@...idwei.uk>, io-uring@...r.kernel.org,
 netdev@...r.kernel.org, Jens Axboe <axboe@...nel.dk>, Paolo Abeni
 <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jesper Dangaard Brouer <hawk@...nel.org>, David
 Ahern <dsahern@...nel.org>, Mina Almasry <almasrymina@...gle.com>,
 Stanislav Fomichev <stfomichev@...il.com>, Joe Damato <jdamato@...tly.com>,
 Pedro Tammela <pctammela@...atatu.com>
Subject: Re: [PATCH net-next v9 08/20] net: expose
 page_pool_{set,clear}_pp_info

On Sat, 21 Dec 2024 01:07:44 +0000 Pavel Begunkov wrote:
> >> Memory providers need to set page pool to its net_iovs on allocation, so
> >> expose page_pool_{set,clear}_pp_info to providers outside net/.  
> > 
> > I'd really rather not expose such low level functions in a header
> > included by every single user of the page pool API.  
> 
> Are you fine if it's exposed in a new header file?

I guess.

I'm uncomfortable with the "outside net/" phrasing of the commit
message. Nothing outside net should used this stuff. Next we'll have
a four letter subsystem abusing it and claiming that it's in a header
so it's a public.

Maybe we should have a conversation about whether io_uring/zcrx.c 
is considered part of networking, whether all patches will get cross
posted and need to get acks from both sides etc. Save ourselves
unpleasant misunderstandings.