netdev - [PATCH 2/2] net/phy,neterion: Remove dead values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241221124445.1094460-3-ariel.otilibili-anieli@eurecom.fr>
Date: Sat, 21 Dec 2024 13:39:33 +0100
From: Ariel Otilibili <ariel.otilibili-anieli@...ecom.fr>
To: linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org
Cc: Ariel Otilibili <ariel.otilibili-anieli@...ecom.fr>,
	Andrei Botila <andrei.botila@....nxp.com>,
	Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>
Subject: [PATCH 2/2] net/phy,neterion: Remove dead values

Coverity-ID: 1269173, 1575053
Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@...ecom.fr>
---
 drivers/net/ethernet/neterion/s2io.c     | 2 --
 drivers/net/phy/nxp-c45-tja11xx-macsec.c | 1 -
 2 files changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c
index f8016dc25e0a..4f89f9fd8043 100644
--- a/drivers/net/ethernet/neterion/s2io.c
+++ b/drivers/net/ethernet/neterion/s2io.c
@@ -1969,8 +1969,6 @@ static void en_dis_err_alarms(struct s2io_nic *nic, u16 mask, int flag)
 				   MC_ERR_REG_ECC_ALL_DBL | PLL_LOCK_N, flag,
 				   &bar0->mc_err_mask);
 	}
-	nic->general_int_mask = gen_int_mask;
-
 	/* Remove this line when alarm interrupts are enabled */
 	nic->general_int_mask = 0;
 }
diff --git a/drivers/net/phy/nxp-c45-tja11xx-macsec.c b/drivers/net/phy/nxp-c45-tja11xx-macsec.c
index 550ef08970f4..e15ab9ba2f50 100644
--- a/drivers/net/phy/nxp-c45-tja11xx-macsec.c
+++ b/drivers/net/phy/nxp-c45-tja11xx-macsec.c
@@ -818,7 +818,6 @@ static void nxp_c45_rx_sc_update(struct phy_device *phydev,
 	u32 cfg = 0;
 
 	nxp_c45_macsec_read(phydev, MACSEC_RXSC_CFG, &cfg);
-	cfg &= ~MACSEC_RXSC_CFG_VF_MASK;
 	cfg = phy_secy->secy->validate_frames << MACSEC_RXSC_CFG_VF_OFF;
 
 	phydev_dbg(phydev, "validate frames %u\n",
-- 
2.47.1