netdev - Re: [PATCH 1/3] drivers/firmware/broadcom, ethernet/marvell: Remove unused values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e99c8ff0-4b72-400b-a530-6808adbd5d1a@lunn.ch>
Date: Sat, 21 Dec 2024 16:17:57 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Ariel Otilibili <ariel.otilibili-anieli@...ecom.fr>
Cc: linux-media@...r.kernel.org, linux-mips@...r.kernel.org,
	netdev@...r.kernel.org, linux-can@...r.kernel.org,
	Rafał Miłecki <zajec5@...il.com>,
	Michael Chan <michael.chan@...adcom.com>,
	Sunil Goutham <sgoutham@...vell.com>,
	Geetha sowjanya <gakula@...vell.com>,
	Subbaraya Sundeep <sbhatta@...vell.com>,
	hariprasad <hkelam@...vell.com>,
	Bharat Bhushan <bbhushan2@...vell.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH 1/3] drivers/firmware/broadcom, ethernet/marvell: Remove
 unused values

On Sat, Dec 21, 2024 at 04:44:15AM +0100, Ariel Otilibili wrote:
> Coverity-IDs: 1487817, 1561102
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@...ecom.fr>

One patch per driver please.

> --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
> @@ -329,11 +329,9 @@ static int cn10k_mcs_write_rx_flowid(struct otx2_nic *pfvf,
>  	mac_da = ether_addr_to_u64(secy->netdev->dev_addr);
>  
>  	req->data[0] = FIELD_PREP(MCS_TCAM0_MAC_DA_MASK, mac_da);
> -	req->mask[0] = ~0ULL;
>  	req->mask[0] = ~MCS_TCAM0_MAC_DA_MASK;
>  
>  	req->data[1] = FIELD_PREP(MCS_TCAM1_ETYPE_MASK, ETH_P_MACSEC);
> -	req->mask[1] = ~0ULL;
>  	req->mask[1] &= ~MCS_TCAM1_ETYPE_MASK;
>  

As i said to another patch, you need to argue why you change is
correct. If you have no idea what the correct fix is, you should
simply report the issue to the Maintainer, and look at the git history
for these lines and see who added them, and ask them what is the
correct fix.

	Andrew